-
Notifications
You must be signed in to change notification settings - Fork 323
Refactored flaky tests in vertex-redis-client-3.9 to retry connection rather than fail with NPE
#9390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ertex-redis test to allow connection retries.
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~e0700b8c5f, baseline=1.53.0-SNAPSHOT~269bad9567
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1057191
Total [baseline] (10.815 s) : 0, 10814766
Agent [candidate] (1.053 s) : 0, 1053415
Total [candidate] (10.854 s) : 0, 10854142
section appsec
Agent [baseline] (1.238 s) : 0, 1237994
Total [baseline] (10.871 s) : 0, 10871431
Agent [candidate] (1.223 s) : 0, 1222640
Total [candidate] (10.821 s) : 0, 10821319
section iast
Agent [baseline] (1.181 s) : 0, 1181074
Total [baseline] (10.962 s) : 0, 10962129
Agent [candidate] (1.178 s) : 0, 1177637
Total [candidate] (10.958 s) : 0, 10957558
section profiling
Agent [baseline] (1.199 s) : 0, 1198768
Total [baseline] (10.957 s) : 0, 10957452
Agent [candidate] (1.205 s) : 0, 1204693
Total [candidate] (10.909 s) : 0, 10908751
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~e0700b8c5f, baseline=1.53.0-SNAPSHOT~269bad9567
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (738.701 ms) : 0, 738701
BytebuddyAgent [candidate] (737.643 ms) : 0, 737643
GlobalTracer [baseline] (244.757 ms) : 0, 244757
GlobalTracer [candidate] (244.264 ms) : 0, 244264
AppSec [baseline] (30.386 ms) : 0, 30386
AppSec [candidate] (30.394 ms) : 0, 30394
Debugger [baseline] (6.073 ms) : 0, 6073
Debugger [candidate] (6.126 ms) : 0, 6126
Remote Config [baseline] (680.298 µs) : 0, 680
Remote Config [candidate] (679.214 µs) : 0, 679
Telemetry [baseline] (13.881 ms) : 0, 13881
Telemetry [candidate] (11.708 ms) : 0, 11708
section appsec
crashtracking [baseline] (1.479 ms) : 0, 1479
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (766.681 ms) : 0, 766681
BytebuddyAgent [candidate] (755.057 ms) : 0, 755057
GlobalTracer [baseline] (237.824 ms) : 0, 237824
GlobalTracer [candidate] (234.757 ms) : 0, 234757
IAST [baseline] (23.748 ms) : 0, 23748
IAST [candidate] (23.587 ms) : 0, 23587
AppSec [baseline] (171.169 ms) : 0, 171169
AppSec [candidate] (168.633 ms) : 0, 168633
Debugger [baseline] (5.774 ms) : 0, 5774
Debugger [candidate] (8.125 ms) : 0, 8125
Remote Config [baseline] (645.87 µs) : 0, 646
Remote Config [candidate] (643.628 µs) : 0, 644
Telemetry [baseline] (9.304 ms) : 0, 9304
Telemetry [candidate] (9.248 ms) : 0, 9248
section iast
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (852.187 ms) : 0, 852187
BytebuddyAgent [candidate] (849.319 ms) : 0, 849319
GlobalTracer [baseline] (234.39 ms) : 0, 234390
GlobalTracer [candidate] (233.194 ms) : 0, 233194
IAST [baseline] (30.279 ms) : 0, 30279
IAST [candidate] (31.004 ms) : 0, 31004
AppSec [baseline] (26.13 ms) : 0, 26130
AppSec [candidate] (26.066 ms) : 0, 26066
Debugger [baseline] (6.644 ms) : 0, 6644
Debugger [candidate] (6.647 ms) : 0, 6647
Remote Config [baseline] (606.041 µs) : 0, 606
Remote Config [candidate] (605.971 µs) : 0, 606
Telemetry [baseline] (8.245 ms) : 0, 8245
Telemetry [candidate] (8.307 ms) : 0, 8307
section profiling
crashtracking [baseline] (1.432 ms) : 0, 1432
crashtracking [candidate] (1.437 ms) : 0, 1437
BytebuddyAgent [baseline] (763.54 ms) : 0, 763540
BytebuddyAgent [candidate] (767.728 ms) : 0, 767728
GlobalTracer [baseline] (222.618 ms) : 0, 222618
GlobalTracer [candidate] (222.573 ms) : 0, 222573
AppSec [baseline] (30.186 ms) : 0, 30186
AppSec [candidate] (30.337 ms) : 0, 30337
Debugger [baseline] (6.333 ms) : 0, 6333
Debugger [candidate] (6.374 ms) : 0, 6374
Remote Config [baseline] (707.094 µs) : 0, 707
Remote Config [candidate] (759.451 µs) : 0, 759
Telemetry [baseline] (16.334 ms) : 0, 16334
Telemetry [candidate] (16.451 ms) : 0, 16451
ProfilingAgent [baseline] (107.845 ms) : 0, 107845
ProfilingAgent [candidate] (109.1 ms) : 0, 109100
Profiling [baseline] (108.468 ms) : 0, 108468
Profiling [candidate] (109.763 ms) : 0, 109763
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~e0700b8c5f, baseline=1.53.0-SNAPSHOT~269bad9567
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1051146
Total [baseline] (8.65 s) : 0, 8649990
Agent [candidate] (1.047 s) : 0, 1047468
Total [candidate] (8.625 s) : 0, 8625492
section iast
Agent [baseline] (1.181 s) : 0, 1181227
Total [baseline] (9.346 s) : 0, 9346405
Agent [candidate] (1.181 s) : 0, 1180700
Total [candidate] (9.338 s) : 0, 9338136
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~e0700b8c5f, baseline=1.53.0-SNAPSHOT~269bad9567
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (734.758 ms) : 0, 734758
BytebuddyAgent [candidate] (731.26 ms) : 0, 731260
GlobalTracer [baseline] (243.23 ms) : 0, 243230
GlobalTracer [candidate] (242.898 ms) : 0, 242898
AppSec [baseline] (30.16 ms) : 0, 30160
AppSec [candidate] (30.291 ms) : 0, 30291
Debugger [baseline] (6.081 ms) : 0, 6081
Debugger [candidate] (6.094 ms) : 0, 6094
Remote Config [baseline] (684.285 µs) : 0, 684
Remote Config [candidate] (690.547 µs) : 0, 691
Telemetry [baseline] (13.706 ms) : 0, 13706
Telemetry [candidate] (13.78 ms) : 0, 13780
section iast
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (851.75 ms) : 0, 851750
BytebuddyAgent [candidate] (852.007 ms) : 0, 852007
GlobalTracer [baseline] (233.586 ms) : 0, 233586
GlobalTracer [candidate] (233.508 ms) : 0, 233508
AppSec [baseline] (25.301 ms) : 0, 25301
AppSec [candidate] (27.786 ms) : 0, 27786
Debugger [baseline] (8.402 ms) : 0, 8402
Debugger [candidate] (5.735 ms) : 0, 5735
Remote Config [baseline] (612.691 µs) : 0, 613
Remote Config [candidate] (594.704 µs) : 0, 595
Telemetry [baseline] (8.306 ms) : 0, 8306
Telemetry [candidate] (8.33 ms) : 0, 8330
IAST [baseline] (30.699 ms) : 0, 30699
IAST [candidate] (30.364 ms) : 0, 30364
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~e0700b8c5f, baseline=1.53.0-SNAPSHOT~269bad9567
dateFormat X
axisFormat %s
section baseline
no_agent (4.448 ms) : 4398, 4498
. : milestone, 4448,
iast (9.45 ms) : 9297, 9602
. : milestone, 9450,
iast_FULL (14.097 ms) : 13818, 14376
. : milestone, 14097,
iast_GLOBAL (10.204 ms) : 10026, 10381
. : milestone, 10204,
profiling (8.76 ms) : 8616, 8904
. : milestone, 8760,
tracing (7.955 ms) : 7841, 8068
. : milestone, 7955,
section candidate
no_agent (4.367 ms) : 4317, 4416
. : milestone, 4367,
iast (9.588 ms) : 9428, 9748
. : milestone, 9588,
iast_FULL (14.412 ms) : 14129, 14695
. : milestone, 14412,
iast_GLOBAL (10.449 ms) : 10267, 10632
. : milestone, 10449,
profiling (8.966 ms) : 8802, 9130
. : milestone, 8966,
tracing (7.936 ms) : 7812, 8059
. : milestone, 7936,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~e0700b8c5f, baseline=1.53.0-SNAPSHOT~269bad9567
dateFormat X
axisFormat %s
section baseline
no_agent (35.953 ms) : 35669, 36236
. : milestone, 35953,
appsec (48.228 ms) : 47805, 48651
. : milestone, 48228,
code_origins (44.637 ms) : 44252, 45022
. : milestone, 44637,
iast (45.608 ms) : 45212, 46005
. : milestone, 45608,
profiling (46.889 ms) : 46467, 47311
. : milestone, 46889,
tracing (42.585 ms) : 42222, 42948
. : milestone, 42585,
section candidate
no_agent (37.174 ms) : 36868, 37481
. : milestone, 37174,
appsec (46.907 ms) : 46494, 47319
. : milestone, 46907,
code_origins (44.378 ms) : 43991, 44766
. : milestone, 44378,
iast (44.805 ms) : 44416, 45194
. : milestone, 44805,
profiling (49.099 ms) : 48663, 49535
. : milestone, 49099,
tracing (43.804 ms) : 43431, 44177
. : milestone, 43804,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~e0700b8c5f, baseline=1.53.0-SNAPSHOT~269bad9567
dateFormat X
axisFormat %s
section baseline
no_agent (15.249 s) : 15249000, 15249000
. : milestone, 15249000,
appsec (14.975 s) : 14975000, 14975000
. : milestone, 14975000,
iast (18.225 s) : 18225000, 18225000
. : milestone, 18225000,
iast_GLOBAL (18.167 s) : 18167000, 18167000
. : milestone, 18167000,
profiling (15.105 s) : 15105000, 15105000
. : milestone, 15105000,
tracing (15.087 s) : 15087000, 15087000
. : milestone, 15087000,
section candidate
no_agent (15.14 s) : 15140000, 15140000
. : milestone, 15140000,
appsec (14.812 s) : 14812000, 14812000
. : milestone, 14812000,
iast (18.572 s) : 18572000, 18572000
. : milestone, 18572000,
iast_GLOBAL (18.334 s) : 18334000, 18334000
. : milestone, 18334000,
profiling (15.286 s) : 15286000, 15286000
. : milestone, 15286000,
tracing (15.156 s) : 15156000, 15156000
. : milestone, 15156000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~e0700b8c5f, baseline=1.53.0-SNAPSHOT~269bad9567
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (3.696 ms) : 3477, 3915
. : milestone, 3696,
iast (2.217 ms) : 2153, 2281
. : milestone, 2217,
iast_GLOBAL (2.257 ms) : 2194, 2321
. : milestone, 2257,
profiling (2.073 ms) : 2020, 2125
. : milestone, 2073,
tracing (2.032 ms) : 1982, 2081
. : milestone, 2032,
section candidate
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.698 ms) : 3478, 3917
. : milestone, 3698,
iast (2.221 ms) : 2157, 2284
. : milestone, 2221,
iast_GLOBAL (2.254 ms) : 2190, 2317
. : milestone, 2254,
profiling (2.067 ms) : 2015, 2118
. : milestone, 2067,
tracing (2.047 ms) : 1997, 2097
. : milestone, 2047,
|
PerfectSlayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the stability improvement
What Does This Do
Reworked connection logic for
vertex-redis-client-3.9test to allow connection retries.Motivation
Tests in
vertex-redis-client-3.9periodically failing with NPEjava.lang.NullPointerException: Cannot invoke method dbsize() on null object, to prevent this I've implemented logic to retry connection to Redis.Additional Notes
Test is passing on CI due to Gradle retries we introduced on build level, but it is visible as flaky test on CI dashboard.